Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5511] create library tests update #3516

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[ACS-5511] create library tests update #3516

merged 2 commits into from
Nov 13, 2023

Conversation

azakrzewski-hy
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Create library tests are failing often and have issues with deleting sites

What is the new behaviour?
Create library tests are done by new user, what helped to search for specific site.
Deleting site was improved as well

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@azakrzewski-hy azakrzewski-hy merged commit 3360473 into develop Nov 13, 2023
29 checks passed
@azakrzewski-hy azakrzewski-hy deleted the ACS-5511-create-library-tests-update branch November 13, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@akashrathod28 akashrathod28 Awaiting requested review from akashrathod28

@MichalKinas MichalKinas Awaiting requested review from MichalKinas

@DenysVuika DenysVuika Awaiting requested review from DenysVuika

@eromano eromano Awaiting requested review from eromano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azakrzewski-hy @AleksanderSklorz